Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

normalize the e2e behavior for npm link in npm 5 and below #3105

Closed
wants to merge 3 commits into from

Conversation

viankakrisna
Copy link
Contributor

@viankakrisna viankakrisna commented Sep 10, 2017

changes in #3026 made some build fails in node 8 (success in #3104 and #3026 , failed in #2755 because of misssing dependencies). probably because npm link behavior is changed in npm 5 http://codetunnel.io/npm-5-changes-to-npm-link/

this PR tries to investigate how to normalize the npm link behavior for e2e in npm 5 and below

@viankakrisna viankakrisna changed the title use cp instead of npm link normalize the e2e behavior with npm 5 and below Sep 10, 2017
@viankakrisna viankakrisna changed the title normalize the e2e behavior with npm 5 and below normalize the e2e behavior for npm link in npm 5 and below Sep 10, 2017
@viankakrisna
Copy link
Contributor Author

viankakrisna commented Sep 10, 2017

`cp: `/home/travis/build/facebookincubator/create-react-app/packages/babel-preset-react-app' and `node_modules/babel-preset-react-app' are the same file`

¯\(ツ)

@viankakrisna
Copy link
Contributor Author

found a related issue npm/npm#16970

@viankakrisna
Copy link
Contributor Author

closing this as it seems that 5.4.1 is not stable enough for npm link (or need us to refactor e2e for it to work)

@viankakrisna viankakrisna deleted the npm5link branch September 14, 2017 15:14
@lock lock bot locked and limited conversation to collaborators Jan 20, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants